librustdoc: Make RenderOptions boolean fields into newtypes#147621
librustdoc: Make RenderOptions boolean fields into newtypes#147621jefftt wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
r? @notriddle rustbot has assigned @notriddle. Use |
This comment has been minimized.
This comment has been minimized.
f39b8ba to
89721a9
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
| pub(crate) generate_macro_expansion: bool, | ||
| pub(crate) generate_macro_expansion: GenerateMacroExpansion, | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you please turn all of them into enum { Yes, No }, that's what's more conventional in this repo (and also what Esteban suggested back then (see the PR linked from the issue)).
|
r? @fmease |
|
|
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
|
☔ The latest upstream changes (presumably #148280) made this pull request unmergeable. Please resolve the merge conflicts. |
closes #87752